Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes leftover from #45636 #45768

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fixes leftover from #45636 #45768

merged 2 commits into from
Aug 23, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 21, 2024 •
edited
Loading

PR description:

quick followup from #45636

PR validation:

Run the following script to test the phase-2 timing menu:

#!/bin/bash -ex

DATASET="/RelValTTbar_14TeV/CMSSW_14_1_0_pre6-PU_141X_mcRun4_realistic_v1_STD_2026D110_PU-v3/GEN-SIM-DIGI-RAW"
ALL_FILES=( $(dasgoclient -query="file dataset=${DATASET}" --limit=-1 | sort | head -4) )

echo $ALL_FILES

cmsDriver.py Phase2 -s L1P2GT,HLT:75e33_timing --processName=HLTX \
  --conditions auto:phase2_realistic_T33 --geometry Extended2026D110 \
  --era Phase2C17I13M9 \
  --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
  --eventcontent FEVTDEBUGHLT \
  --filein=${ALL_FILES} \
  --mc --nThreads 4 --inputCommands='keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT' \
  -n 1000 --no_exec

No regression expected as this product should not be consumed in the menu, see #45636 (comment)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Aug 21, 2024
@mmusich mmusich mentioned this pull request Aug 21, 2024
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45768/41482

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 21, 2024

@cmsbuild, please test

@mmusich mmusich force-pushed the mm_dev_fixup_forPhase2HLT_renaming branch from 048e0c2 to 6524606 Compare August 22, 2024 10:35
@mmusich mmusich changed the title fixup for product label from #45636 fixes leftover from #45636 Aug 22, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45768/41495

@cmsbuild
Copy link
Contributor

Pull request #45768 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 22, 2024

enable hlt_p2_timing

@mmusich
Copy link
Contributor Author

mmusich commented Aug 22, 2024

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Aug 22, 2024

type bug-fix

@mmusich mmusich mentioned this pull request Aug 22, 2024
Merged
@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7c1465/41085/summary.html
COMMIT: 6524606
CMSSW: CMSSW_14_1_X_2024-08-22-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45768/41085/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

  • 2024.00012024.0001_RunBTagMu2024B_1M/step1_dasquery.log
  • 2024.001052024.00105_RunDisplacedJet2024B_500k/step1_dasquery.log
  • 2024.202052024.20205_RunEGamma02024D_500k/step1_dasquery.log
Expand to see more relval errors ...

Comparison Summary

Summary:

@mmusich
Copy link
Contributor Author

mmusich commented Aug 23, 2024

@cmsbuild ignore tests-rejected with ib-failure

@mmusich
Copy link
Contributor Author

mmusich commented Aug 23, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1d42f0 into cms-sw:master Aug 23, 2024
11 of 12 checks passed
@mmusich mmusich deleted the mm_dev_fixup_forPhase2HLT_renaming branch August 23, 2024 20:05
@mmusich
Copy link
Contributor Author

mmusich commented Aug 24, 2024

For the record, the phase2 timing monitoring works again as of CMSSW_14_1_X_2024-08-23-2300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved fully-signed hlt-approved orp-approved tests-approved tests-ib-failure
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@mmusich @cmsbuild @mandrenguyen